Revert "server: factor out MainCommon as a class, with a run method (…#2613
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Feb 15, 2018
Merged
Revert "server: factor out MainCommon as a class, with a run method (…#2613htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
…nvoyproxy#2568)" This reverts commit deffec6, which was causing CI to flake today in TSAN runs. The proximate root cause is the change in envoyproxy#2568, which appears not to correctly setup logging in --mode=validate. This in turn leads to some log related races that I don't fully grok. Rolling back to unblock CI, we should make sure hotrestart_test passes TSAN with high confidence before rolling forward again. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@jmarantz @envoyproxy/maintainers Apologies for the rollback, but this will unblock CI. We should try and figure out what's up with |
Contributor
|
Sorry about the regression! I wonder if this would've been easier to catch with the thread annotation you've now enabled? |
jmarantz
approved these changes
Feb 15, 2018
Member
Author
|
@jmarantz Yeah, it will be interesting to understand the underlying race; I think somehow we were getting default logging initialization effects rather than a full initialization prior to threads launching (which were then logging). Some of the locking around logging could benefit from thread annotations. |
This was referenced Feb 15, 2018
jmarantz
added a commit
to jmarantz/envoy
that referenced
this pull request
Feb 15, 2018
…method (envoyproxy#2568)" (envoyproxy#2613)" This reverts commit 034135f. Signed-off-by: Joshua Marantz <jmarantz@google.com>
dnoe
pushed a commit
that referenced
this pull request
Feb 15, 2018
…ation (#2623) Description: Reverts #2613 the revert of #2568 Fixed the underlying issue which was that logging was not initialized during validation, so it ran lockless. This caused intermittent tsan errors. Although #2619 makes the failure immediate and consistent by asserting that logging has been initialized prior to spawning any threads. Risk Level: Medium -- the earlier #2568 caused intermittent tsan errors which we believe to be fixed, but #2568 was medium-risk in the first place. Release Notes: N/A
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
This can save ~1ms at batch size == 100.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Risk Level: low Testing: unit tests Docs Changes: n/a Release Notes: yes Part of #1594 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Risk Level: low Testing: unit tests Docs Changes: n/a Release Notes: yes Part of #1594 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#2568)"
This reverts commit deffec6, which was
causing CI to flake today in TSAN runs. The proximate root cause is
the change in #2568, which appears not to correctly setup logging in
--mode=validate. This in turn leads to some log related races that I
don't fully grok.
Rolling back to unblock CI, we should make sure hotrestart_test passes
TSAN with high confidence before rolling forward again.
Risk Level: Low
Testing: bazel test //test/integration:hotrestart_test --runs_per_test=100 --config=clang-tsan -c dbg
Signed-off-by: Harvey Tuch htuch@google.com